[sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

Marco Pesenti Gritti mpgritti at gmail.com
Sun Jun 8 15:42:33 EDT 2008


On Sun, Jun 8, 2008 at 9:26 PM, Jameson Chema Quinn
<jquinn at cs.oberlin.edu> wrote:
> Here is the revised patch. It has your suggested changes, plus a couple
> more:
>
> - Check for existence of po directory in Builder
> - Config.__init__() is cleaned up. Now gets bundle name from activity.info.
> start() no longer needs a bundle name, and has deprecation warning. Also I
> put things in a more logical order.

Jameson,

*please* do *not* make any additional changes when submitting a new
patch. Limit yourself to the changes requested by the reviewer.
Additional fixes/improvements should go in a separate patch.

I'll review it as is this time, but next time I'm going to ask you to
take out the additional changes.

Thanks,
Marco


More information about the Sugar mailing list