[sugar] [PATCH] Add speaker device and icon by default

Tomeu Vizoso tomeu at tomeuvizoso.net
Mon Apr 28 09:49:12 EDT 2008


On Fri, Apr 25, 2008 at 11:50 PM, Martin Dengler
<martin at martindengler.com> wrote:

>  +        self.palette = SpeakerPalette(_('My Speakers'), model=model)
>  +        self.set_palette(self.palette)

'set_palette' is the setter for the 'palette' property, so the second
line shouldn't be needed.

>  +        model.connect('notify::level', self._speaker_status_changed_cb)
>  +        model.connect('notify::muted', self._speaker_status_changed_cb)
>  +        self.connect('expose-event', self._expose_event_cb)

Callbacks should start with two underscores in order to avoid name clashes.

The rest looks good to me.

Thanks,

Tomeu


More information about the Sugar mailing list