[sugar] [PATCH] Add speaker device and icon by default

Martin Dengler martin at martindengler.com
Sat Apr 26 08:56:58 EDT 2008


On Sat, Apr 26, 2008 at 06:07:45AM -0400, Wade Brainerd wrote:
> On Fri, Apr 25, 2008 at 1:56 PM, Eben Eliason <eben.eliason at gmail.com> wrote:
> > On Fri, Apr 25, 2008 at 1:46 PM, Martin Dengler
> >  >  self._mute_item.get_child().set_text(_(mute_item_text))
> >
> >  Oh, I missed that.  I would wrap the localization around the string
> >  literal, so the connection is clear. (Yes, you have to use it twice
> >  instead of once....but it was imported as _ for a reason. ;) )
> 
> Won't gettext fail to pick these up when generating the .pot file, the
> way it's written now?
> 
> I was under the impression it just looks blindly through the source
> for _(<quoted string>) when building the translation files...

Yes -- I didn't know this at the time.  Thanks for pointing it out.
Others pointed it out to me on IRC, too, and my most recent patch
addresses the point.  Thanks again for the time/feedback.

> Wade

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080426/3e863219/attachment.pgp 


More information about the Sugar mailing list