[sugar] [PATCH] sugar pylint (vol2)

Marco Pesenti Gritti mpgritti at gmail.com
Tue Apr 22 09:03:47 EDT 2008


On Tue, Apr 22, 2008 at 2:47 PM, Simon Schampijer <simon at schampijer.de> wrote:
> Hi,
>
>  two more patches for pylint. One thing that I have not solved yet in the
> lint_intro patch is the problem that pylint is not aware of members of the
> window class. I think that is the case because the gtk.gdk.window is only
> available when the window is realized.
>
>  - window xid: shell/intro/glive.py
>   - Class 'window' has no 'xid' member
>   - other examples: set_type_hint, set_accept_focus...

I worked these around with a patch to our pylint. If you do a clean
jhbuild you should have these solved.

>  Another issue I have quite often is the one of unused variables due to
> returned tuples and lists where not all the variables are used in the code.
>
>  examaple from src/view/frame/clipboardpanelwindow.py:
>
>  scheme, netloc, path, parameters, query, fragment = urlparse.urlparse(uri)
>
>  on_disk = (scheme == 'file')
>
>  What about doing here, or any other options?
>  scheme = urlparse.urlparse(uri)[0]

That's what I've been doing. Better ideas welcome.

Marco


More information about the Sugar mailing list