[sugar] [PATCH] Add prelight to buttons in Journal list

Eben Eliason eben.eliason at gmail.com
Sat Apr 19 13:57:44 EDT 2008


On Sat, Apr 19, 2008 at 7:00 AM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
>
> On Thu, Apr 17, 2008 at 6:18 AM, Eben Eliason <eben.eliason at gmail.com> wrote:
>  > These two patches are both pretty simple, and each add a prelight
>  >  state to buttons in the list view of the Journal.  I include them
>  >  together as they're similar, but also because they both suffer a
>  >  common glitch, which I'm going to assume is a bug in Hippo.  Despite
>  >  connecting to MOTION_NOTIFY events for both ENTER and LEAVE, the
>  >  prelight states only appear when the mouse is clicked on the icons.
>  >  Something in the event processing is acting strangely.
>  >
>  >  Ideas as to the cause (or corrections of a stupid mistake of my own)
>  >  are appreciated.
>
>  Patches look good. About why prelight doesn't work, may be because
>  CanvasIcon or the container box are incorrectly handling this same
>  signal so it doesn't get propagated somehow? Adding debug statements
>  to the handlers for this signal in canvasicon and the container may be
>  useful.

Hmm, maybe.  I'll give it a shot.  However, I did actually attempt to
achieve this effect with both the motion-notify event and also the
hovering-changed event, which seem to serve basically the same
purpose.  I find it unlikely that their containers would be
incorrectly handling both types of signals.

- Eben


More information about the Sugar mailing list