[sugar] [PATCH] (Incomplete) Activity Launch Feedback

[Eben Eliason]

Here's my second pass at the launcher patch.  This version changes
little in the actual behavior of the code, but substantially cleans up
the code itself.  I pulled all of the "pending_activity" code out,
simplifying the model a good deal, as we no longer need it with the
new Home design.  I also re-factored the flow of the launch (and
launch failed) notifications, unifying so that everything occurs first
in the model which then sends signals to the view, rather than having
the view call the model in some cases and vice versa, which led to
inconsistencies.

These changes also made the calls to notify_launch in the shell
cleaner, passing the home_activity object instead of several other
parameters, which in turn cleaned up the call stack for
setting/changing the launching activity icon.  I'm much more satisfied
here.

The main problem that remains is that the launching activity feedback
is still mostly maintained within the view.  The model remains
unchanged from before.  We need to clean this up so that a launching
activity (which doesn't yet have a window) can still be considered
active in the model, so that the view always properly reflects the
model instead of tiptoeing around it to achieve the launching feedback
effect.

Thoughts on how to best achieve this goal are welcomed, as it gets a
bit more intimate with the window management business that I'm
unfamiliar with.

- Eben


On Thu, Apr 17, 2008 at 1:19 AM, Eben Eliason <eben.eliason at gmail.com> wrote:
> This patch is mainly for Marco, who plans to help me finish and clean
>  up the new activity launcher.  It's currently full of TODOs, comments,
>  temporary hacks, etc, but it's in a "nearly complete" state inasmuch
>  as it will run smoothly despite the partially unfinished and poorly
>  styled implementation.
>
>  Also, launchbox.py is a new file to be added to src/view/home/ in
>  addition to applying the patch, and of course you'll need to edit the
>  Makefile to include it as well.
>
>  Marco, take a peek at the various comments I've made; I look forward
>  to hearing your thoughts on the remainder.  It's looking good so far.
>
>  - Eben
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: activity_launch_feedback.patch
Type: text/x-patch
Size: 25170 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080418/33df88c4/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: launchbox.py
Type: text/x-python
Size: 4316 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080418/33df88c4/attachment-0001.py