[sugar] [PATCH] add a secondary label and icon to palettes WAS Merging sugar-toolkit changes from tomeu repository

Eben Eliason eben.eliason at gmail.com
Tue Apr 1 15:26:40 EDT 2008


A few minor fixes.

- Eben


On Tue, Apr 1, 2008 at 2:20 PM, Eben Eliason <eben.eliason at gmail.com> wrote:
> OK, here's a newer version of the patch.  It removes the
>  menu_after_content property and associated code, puts a DEPRECATED
>  comment with the Palette constructor for future reference, ensures
>  that the icon passed gets set to the correct size, and cuts a few
>  lines of previously commented code that are no longer needed.
>
>  - Eben
>
>
>
>  On Tue, Apr 1, 2008 at 10:53 AM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
>  > On Tue, Apr 1, 2008 at 4:30 PM, Marco Pesenti Gritti <mpgritti at gmail.com> wrote:
>  >  > Padding and spacing are property of the container, not of the icon.
>  >  >  It's common practice in gtk to have menu and toolbars set the icon
>  >  >  size, so I don't think that would be confusing.
>  >
>  >  So let's ship it!
>  >
>  >  Tomeu
>  >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-New-palette-API.patch
Type: text/x-patch
Size: 11931 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080401/37773dfe/attachment-0001.bin 


More information about the Sugar mailing list