[sugar] [PATCH] olpc.datastore.dbus_helpers: Stop using internal interfaces in dbus-python.

[Dan Williams]

On Tue, 2007-05-22 at 11:26 +0100, Simon McVittie wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> _dbus_bindings is a private implementation detail with no API guarantees;
> it may change incompatibly (or cease to exist) at any time. If you need the
> low-level, message-based API, use dbus.lowlevel instead.

Looks fine to me.

> Patch also available in http://projects.collabora.co.uk/~smcv/git/datastore.git
> - ---
>  src/olpc/datastore/dbus_helpers.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/olpc/datastore/dbus_helpers.py b/src/olpc/datastore/dbus_helpers.py
> index 5b712fd..b706741 100644
> - --- a/src/olpc/datastore/dbus_helpers.py
> +++ b/src/olpc/datastore/dbus_helpers.py
> @@ -1,6 +1,6 @@
>  import olpc.datastore.utils
>  import dbus
> - -import _dbus_bindings
> +from dbus.lowlevel import SignalMessage
>  
> 
>  # A dbus signal emitter factory
> @@ -13,7 +13,7 @@ class emitter(object):
>      """
>      def __init__(self, bus, obj_path, dbus_interface):
>          self._connection = bus.get_connection()
> - -        self.message = olpc.datastore.utils.partial(_dbus_bindings.SignalMessage, obj_path,
> +        self.message = olpc.datastore.utils.partial(SignalMessage, obj_path,
>                                                      dbus_interface)
>  
>      def __call__(self, name, *args, **kwargs):
> - -- 
> 1.5.2-rc3.GIT
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: OpenPGP key: http://www.pseudorandom.co.uk/2003/contact/ or pgp.net
> 
> iD8DBQFGUsVpWSc8zVUw7HYRAvgoAKCbsY0rQGNcbt4nugs3JWKHTY4m1gCffLzk
> wIVj4YQBnkSBP3JNgGKuKp0=
> =tZFa
> -----END PGP SIGNATURE-----
> _______________________________________________
> Sugar mailing list
> Sugar at laptop.org
> http://mailman.laptop.org/mailman/listinfo/sugar