[linux-mm-cc] [RFC] LZO de/compression support - take 3

Nitin Gupta nitingupta910 at gmail.com
Wed May 23 10:03:36 EDT 2007


On 5/23/07, Michael-Luke Jones <mlj28 at cam.ac.uk> wrote:
>
> Fair enough. However, this rather important issue is pretty much
> undocumented (source code comments don't count)

If header file for public interface (<linux/lzo1x.h> documents about
'unsafe' vs. 'safe' then it should be enough.

> and Reiser4 is
> already using the lzo1x_decompress() function rather than the
> seemingly more appropriate lzo1x_decompress_safe() function...
>
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-
> rc2/2.6.22-rc2-mm1/broken-out/reiser4-use-lzo-library-functions.patch
>
> Perhaps a rename is in order:
> lzo1x_decompress() => lzo1x_decompress_unsafe()
> lzo1x_decompress_safe => lzo1x_decompress()
>

Or perhaps make reiserfs use _safe() instead - I think Richard has
already submitted patch for same.

- Nitin


More information about the linux-mm-cc mailing list