[linux-mm-cc] [PATCH] fix to enable to build with O option

[Nitin Gupta]

Hi,

On 5/9/07, IKEDA Munehiro <m-ikeda at ds.jp.nec.com> wrote:
> I found a problem to make lib/* with "O" option like
>   make O=../build bzImage
>
> This probelem was caused by that "lib-y" can't properly handle a file
> in sub-directory.
> So this patch modifies and creates makefiles to fix it.
> By this patch, minilzo.o, WKdm.o, and WK4x4.o will not be archived in
> lib/lib.a.  As far as I know it has no problem ... doesn't it?
>

No, there shouldn't be any problem. I don't know why we don't hit this
problem without the 'O' make option but nevertheless listing them as
"obj-y" succeeds in all cases. So, I will get this change in next
release.

> This patch is for patch-ccache-alpha-008-2.6.21 applied kernel.
>
> Note (1) ---
> Now all of 3 algos are always compiled because they are listed in "obj-y".
> Yes, I know the best way is defining CONFIG_* for each compression algo
> and then modifing the makefiles as the ToDo 3) a) ii) says.  So this
> patch is just a "patch" literally, and has to be fixed again when the
> ToDo is done.
>

But still, your patch fixes a build issue, so I will get it in before
we get the "proper" fix :)

> Note (2) ---
> minilzo is currently beeing pushed in mainline.  If you don't know,
> please see
> http://www.ussg.iu.edu/hypermail/linux/kernel/0705.0/1963.html
> IMHO, we should collabotare with the action.
>

Ahoy! I didn't know about it. Currently LZO code is a huge mess in
ccache and large (non-trivial) work required for clean-ups.  We can
surely look into LZO port they have done (maybe we'll require to
modify it for our purpose).


Thanks for the changes.


Cheers,
Nitin