mmp-camera DMA crash fix

[Martin Langhoff]

Hi Jon, Saadia, all

in my initial testing, this seems to be working _much_ better.

 - I don't get garbled audio

 - I don't get crashes

 - dmesg shows lots of cma dma_alloc_from_contiguous() and
vb2_common_vm_{open,close} spam

 - the captured picture is always greenish, with the top band in a
different luminance, this does not happen if I just take a picture,
without involving audio

This is of course minor :-)

cheers,


martin

On Sat, Mar 17, 2012 at 10:53 AM, Martin Langhoff <martin at laptop.org> wrote:
> We have what looks like a fix for the Record crash! Yum update your
> kernel and rsync the kernel+inird into place, and help us test :-)
>
>
>
> m
>
> On Sat, Mar 17, 2012 at 10:15 AM, Saadia Husain Baloch
> <saadia at laptop.org> wrote:
>> Jon C.
>> These are definitely a breakthrough! I have not been able to crash Record
>> (and I'm good at managing crashes), and there are no green screens of death
>> either. Chris Ball has pushed them to our code tree so more people can test
>> them as well.
>> I have noticed one thing in the short testing I did this morning: the audio
>> is garbled/unintelligible on these recorded segments. Let me see if anyone
>> else is experiencing this, but I didn't have it before.
>> Thank you for all your help
>> -Saadia
>>
>>
>> On Fri, Mar 16, 2012 at 6:51 PM, Jonathan Corbet <corbet at lwn.net> wrote:
>>>
>>> On Fri, 16 Mar 2012 14:53:58 -0600
>>> Jonathan Corbet <corbet at lwn.net> wrote:
>>>
>>> > I want to pound on it for a bit longer, then I'll have a set of patches
>>> > to
>>> > send in.  Stay tuned...
>>>
>>> And now they are ready.  There's a whole set of stuff in my repo,
>>> including the other bug fixes I've sent around, a couple you haven't seen
>>> yet (including one for #11644), and, at the end of the series, the
>>> demotion of the "Release" printk spam to debug level.
>>>
>>> With these patches in, I cannot make my machine crash no matter how hard I
>>> try; I think the problems are truly stomped.  My apologies for creating
>>> them in the first place and causing you to lose a lot of time.
>>>
>>> jon
>>>
>>> The following changes since commit
>>> 943cd42c06440bbc139b775a73fbf55786e44087
>>> are available in the git repository at:
>>>
>>>  git://git.lwn.net/linux-2.6.git olpc-camera-fixes
>>>
>>> for you to fetch changes up to 3b944fd17f650c9f589924f0f26de7c36c444516:
>>>
>>>  marvell-cam: Demote the "release" print to debug level (2012-03-16
>>> 16:29:50 -0600)
>>>
>>> ----------------------------------------------------------------
>>> Jonathan Corbet (7):
>>>      marvell-cam: ensure that the camera stops when requested
>>>      marvell-cam: Remove broken "owner" logic
>>>      marvell-cam: Increase the DMA shutdown timeout
>>>      marvell-cam: fix the green screen of death
>>>      marvell-cam: Don't signal multiple frame completions in
>>> scatter/gather mode
>>>      mmp-camera: Don't power up the sensor on resume
>>>      marvell-cam: Demote the "release" print to debug level
>>>
>>>  drivers/media/video/marvell-ccic/mcam-core.c  |   35
>>> ++++++++++++++++--------
>>>  drivers/media/video/marvell-ccic/mcam-core.h  |    1 -
>>>  drivers/media/video/marvell-ccic/mmp-driver.c |   13 ++++++---
>>>  3 files changed, 32 insertions(+), 17 deletions(-)
>>
>>
>
>
>
> --
>  martin at laptop.org -- Software Architect - OLPC
>  - ask interesting questions
>  - don't get distracted with shiny stuff  - working code first
>  - http://wiki.laptop.org/go/User:Martinlanghoff



-- 
 martin at laptop.org -- Software Architect - OLPC
 - ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff