Lost "activity failed to launch" smarts in Sugar launch splash

[manuel quiñones]

2011/8/31 Gonzalo Odiard <gonzalo at laptop.org>:
>
>
> On Tue, Aug 30, 2011 at 9:06 PM, Martin Langhoff <martin at laptop.org> wrote:
>>
>> Hi Gonzalo,
>>
>> on os41, if you launch Maze, it fails to start (that's logged
>> already)... and the launcher fails to register the failure, which I
>> don't think has been discussed.
>>
>> shell.log says "ERROR root: Cannot send NotifyLaunchFailure to the
>> shell" -- could this be related to the new activity startup splash? Is
>> this otherwise known?
>>
>
> No, is not related.
> Maze is really broken, but one of the problems (already solved in git)
> is the configuration in the activity.info file and sugar can start the
> activity.
> (the line exec should be "exec = sugar-activity activity.MazeActivity)
> If you want try, must restart sugar after editing the file because are
> cached.

The fix is very simple, a change on a string (the string needs to
match a module that contains the game loop in a function called main).
 I wonder why someone would change the code and commit before even
checking the activity starts!  I will send the fix to sugarlabs ml.

diff --git a/activity.py b/activity.py
index dbf6940..f21efdd 100755
--- a/activity.py
+++ b/activity.py
@@ -4,6 +4,6 @@ from gettext import gettext as _


 class MazeActivity(olpcgames.PyGameActivity):
-    game_name = 'maze'
+    game_name = 'game'
     game_title = _('Maze')
     game_size = None    # let olpcgames pick a nice size for us


>
> Gonzalo
>
>>
>> cheers,
>>
>>
>>
>> m
>> --
>>  martin at laptop.org -- Software Architect - OLPC
>>  - ask interesting questions
>>  - don't get distracted with shiny stuff  - working code first
>>  - http://wiki.laptop.org/go/User:Martinlanghoff
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.laptop.org
> http://lists.laptop.org/listinfo/devel
>
>



-- 
.. manuq ..