[PATCH olpc-os-builder] Add support for (non-recursively) including config files in the build config

Sascha Silbe sascha-ml-reply-to-2011-2 at silbe.org
Sat Apr 9 12:56:26 EDT 2011


Excerpts from Daniel Drake's message of Sat Apr 09 18:19:36 +0200 2011:
> On 2 April 2011 18:33, Sascha Silbe <silbe at activitycentral.com> wrote:
> > This is useful for building several similar, but distinct images (e.g.
> > XO-1 vs. XO-1.5, Gnome vs. no Gnome).
> 
> I think it would make more sense (and be more simplistic) to just
> allow multiple config files to be passed on the command line.
> osbuilder would then parse them all, in that order. What do you think?

That would require the caller to specify all of them. E.g. to build
Dextrose 3 without Gnome on XO-1.5, the invocation would become:

sudo ./osbuilder.py config/dextrose3-common.ini config/dextrose3-xo1.5-common.ini config/dextrose3-xo1.5-nognome.ini

instead of:

sudo ./osbuilder.py config/dextrose3-xo1.5-nognome.ini


One could hide that behind a script or a Makefile, but inclusions in the
config files should be easier to set up for the o-o-b user (e.g. a
deployment).

We might set up a Makefile based system for Dextrose anyway (because we
also need to build a few RPMs) so it doesn't matter much for us; I'd
expect it to make more of a difference for small deployments (with
limited technical staff). But if you still prefer the CLI based
approach, I'm happy to prepare a new patch.

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 500 bytes
Desc: not available
URL: <http://lists.laptop.org/pipermail/devel/attachments/20110409/45797262/attachment.sig>


More information about the Devel mailing list