bitfrost assertion checks were lost

James Cameron quozl at
Tue Jul 6 19:32:43 EDT 2010

On Tue, Jul 06, 2010 at 12:27:24PM -0600, Daniel Drake wrote:
> A few months ago we enabled Python optimizations in the OLPC builds
> causing python's "assert" statement to do nothing.
> Martin Langhoff pointed out that we're dropping some important parts
> of bitfrost's code with this change - we do want to be making these
> checks.
> Here's a patch to restore the previous behaviour, review appreciated.

Since the git commit ea73e4a was slightly later, I reviewed that.  No
issues found.  I've also tested to my satisfaction that assert(False)
does nothing when python -O is run, and raising AssertionError is still

Reviewed-by: James Cameron <quozl at>

James Cameron

More information about the Devel mailing list