[PATCH 0/3] olpc-battery: add properties needed by UPower

[Andres Salomon]

On Wed, 22 Dec 2010 03:21:42 +0300
Anton Vorontsov <cbouatmailru at gmail.com> wrote:

> On Fri, Dec 10, 2010 at 11:05:18PM +0100, Sascha Silbe wrote:
> > With these patches applied, UPower correctly calculates Percentage,
> > TimeToEmpty and TimeToFull for OLPC batteries.
> > 
> > Sascha Silbe (3):
> >   olpc-battery: add support for CHARGE_FULL_DESIGN
> >   olpc-battery: add support for CHARGE_NOW
> >   olpc-battery: add support for CURRENT_NOW and VOLTAGE_NOW
> > 
> >  drivers/power/olpc_battery.c |   82
> > ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 82
> > insertions(+), 0 deletions(-)
> 
> Technically, the patches look good. But I'm not sure about the
> EC/Device-tree thing. Is there any consensus? Should I just
> apply the patches, so the remaining issues could be fixed
> later?
> 
> Thanks,
> 


Given that OLPC machines out there currently have broken battery
information with UPower and friends, I think that the patches should be
applied.

Doing stuff in the EC or device-tree may be done in the future, but
even after it's written & debugged, it will still take some time for
people to upgrade their firmware.