[PATCH 1/3] olpc-battery: add support for CHARGE_FULL_DESIGN

Paul Fox pgf at laptop.org
Fri Dec 10 21:41:00 EST 2010


i'm pretty sure those numbers (and the corresponding numbers from the
1.5 DSDT) came from the battery manufacturer.  obviously we could move
the data to the EC, but i'm not sure what the advantage of that would
be.  i know that the numbers don't come from the battery itself.

paul

mitch wrote:
 > By not providing more information, I was sending a subtle signal that I 
 > am busy with something else right now and do not want to go into 
 > "digging up everything I know or can find out about batteries" mode at 
 > the moment.
 > 
 > 
 > On 12/10/2010 3:09 PM, Andres Salomon wrote:
 > > On Fri, 10 Dec 2010 14:56:15 -1000
 > > Mitch Bradley<wmb at laptop.org>  wrote:
 > >
 > >> There is some battery info in the _BIF (battery info) method in the
 > >> BATT node of the ACPI DSDT.  I don't remember if it is correct or
 > >> not.  The numbers below match the DSDT numbers.
 > >
 > > Wait, so where did *those* numbers come from?  A spec somewhere, the
 > > EC, or did you actually reverse engineer them?
 > >
 > > (Note that ACPI is only available on XO-1.5, so pulling them from ACPI
 > > on XO-1 isn't an option.)
 > >
 > >
 > >
 > >>
 > >> On 12/10/2010 2:38 PM, Andres Salomon wrote:
 > >>> On Fri, 10 Dec 2010 22:15:10 +0000
 > >>> David Woodhouse<dwmw2 at infradead.org>   wrote:
 > >>>
 > >>>> On Fri, 2010-12-10 at 23:05 +0100, Sascha Silbe wrote:
 > >>>>>
 > >>>>> +
 > >>>>> +       switch (tech.intval) {
 > >>>>> +       case POWER_SUPPLY_TECHNOLOGY_NiMH:
 > >>>>> +               switch (mfr) {
 > >>>>> +               case 1: /* Gold Peak */
 > >>>>> +                       val->intval = 3000000*.8;
 > >>>>> +                       break;
 > >>>>> +               default:
 > >>>>> +                       return -EIO;
 > >>>>> +               }
 > >>>>> +               break;
 > >>>>> +
 > >>>>> +       case POWER_SUPPLY_TECHNOLOGY_LiFe:
 > >>>>> +               switch (mfr) {
 > >>>>> +               case 1: /* Gold Peak */
 > >>>>> +                       val->intval = 2800000;
 > >>>>> +                       break;
 > >>>>> +               case 2: /* BYD */
 > >>>>> +                       val->intval = 3100000;
 > >>>>> +                       break;
 > >>>>> +               default:
 > >>>>> +                       return -EIO;
 > >>>>> +               }
 > >>>>> +               break;
 > >>>>> +
 > >>>>> +       default:
 > >>>>> +               return -EIO;
 > >>>>> +       }
 > >>>>> +
 > >>>>> +       return ret;
 > >>>>> +}
 > >>>>
 > _______________________________________________
 > Devel mailing list
 > Devel at lists.laptop.org
 > http://lists.laptop.org/listinfo/devel

=---------------------
 paul fox, pgf at laptop.org



More information about the Devel mailing list