[PATCH stable] Separate multicast configuration for mesh and wlan interfaces.
dcbw at redhat.com
Mon May 19 07:21:40 EDT 2008
On Mon, 2008-05-19 at 12:05 +0100, David Woodhouse wrote:
> On Mon, 2008-05-19 at 07:01 -0400, Dan Williams wrote:
> > Is the firmware multicast address limit the same for every firmware from
> > 5.0.x up to 9? Is it something that people with the firmware dev kit
> > can change with a recompile? Because if it changes between any of the
> > firmware revisions already out there (including for 8385 CF, 8686 SDIO,
> > 8388 USB, etc) then we'll probably need a lookup table.
> If we can avoid a lookup table, that would be nice. Perhaps we could
> list the MAC addresses after trying to set them, and see how many we get
> back? Unless there's a better way...
That wouldn't help if some version of firmware couldn't handle the case
when it's given more than it's max (see below).
> > I just hope the different firmwares does something sensible when they
> > get more than they can handle?
> Like automatically going into ALLMULTI mode? That would be nice, but I
> find it unlikely.
No, like not bounds-checking the given list against an internal max
value and overrunning a buffer, because it expects the driver to be
bounds-checking the value and not giving it more than it can handle.
That's probably not the case, but would be nice to have some
confirmation that various firmware versions do handle this OK. If they
do, then we can play some tricks like reading it back to see if they all
get set correctly or whatnot.
More information about the Devel