[PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

Dan Williams dcbw at redhat.com
Tue May 13 11:54:38 EDT 2008


On Fri, 2008-05-16 at 17:51 +0200, Stefanik Gábor wrote:
> On Fri, May 16, 2008 at 4:50 PM, Johannes Berg
> <johannes at sipsolutions.net> wrote:
> > On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote:
> >> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
> >> > This patch is based on a patch from Shailendra Govardhan.  It introduces
> >> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan
> >> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
> >> > {get,set}_def_meshid.  These commands are only supported on Marvell hardware
> >> > that implements persistent defaults, such as the OLPC Active Antenna.
> >> > Accordingly, this patch may not be suitable for upstream merging.
> >
> >> But this is the _one_ thing which might actually be OK to do with a
> >> private ioctl, since it's very hardware-specific. Unlike like all the
> >> mesh-mangling stuff where we really ought to be compatible with o11s.
> >>
> >> So maybe, just maybe, we _can_ do this with iwpriv and push that
> >> upstream.
> >
> > Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl80211 so
> > that we can kill wext at some point.
> >
> > Or maybe this should be in sysfs or so?
> >
> > johannes
> >
> 
> Or maybe in configfs? That's a better place for configuration options.
> (BTW rt2x00 uses debugfs as an iwpriv replacement, so that's another
> possibility.)

I keep proposing debugfs too, but in some cases the commands aren't just
for poking around with stuff.  configfs is probably a better answer to
tweakables that aren't just ricer-geekporn.

Dan




More information about the Devel mailing list