[PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

David Woodhouse dwmw2 at infradead.org
Fri May 16 10:09:09 EDT 2008


On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
> This patch is based on a patch from Shailendra Govardhan.  It introduces
> several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan
> {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
> {get,set}_def_meshid.  These commands are only supported on Marvell hardware
> that implements persistent defaults, such as the OLPC Active Antenna.
> Accordingly, this patch may not be suitable for upstream merging.
> 
> See http://dev.laptop.org/ticket/6823 for minimal testing results and known
> issues.  See http://www.laptop.org/teamwiki/index.php/Tech:Wireless#Firmware_image_which_stores_the_mesh_parameters_in_flash for iwpriv documentation.
> 
> Signed-off-by: Brian Cavagnolo <brian at cozybit.com>
> ---

Hm. I was intending to veto the addition of any more private ioctls to
the olpc tree, because they all need fixing to use cfg80211 or something
else upstream, and we only make pain for ourselves by adding to the
divergence -- adding new APIs to userspace when we _know_ are going to
have to change them is just silly.

But this is the _one_ thing which might actually be OK to do with a
private ioctl, since it's very hardware-specific. Unlike like all the
mesh-mangling stuff where we really ought to be compatible with o11s.

So maybe, just maybe, we _can_ do this with iwpriv and push that
upstream.

If you want to revamp the patch to apply to the upstream kernel and see
what people think of it, go ahead.

-- 
dwmw2




More information about the Devel mailing list