Clipboard[PATCH]

[Tomeu Vizoso]

On 4/18/08, Eric Burns <ericjosephburns at gmail.com> wrote:
> This patch disables the frame from popping up when you copy an object to the
> clipboard and instead pops up a notification icon in the bottom left hand
> corner. It also adds the ability to add_notification() for future use to
> place icons in any of the four corners.

Hi Eric, sorry for replying so late:

+            # Display the notification icon for the clipping

this comment seems redundant to me (context is clear enough)

+            self._notif_icon.props.xo_color = profile.get_color()

I think that the notification should have the same color as the
clipboard icon, that could be different from the local xo color (not
currently, but that's the idea).

+            view.frame.frame.get_instance().add_notification(self._notif_icon,
'top-right')

I think it's better to use a constant here, instead of passing
'top-right'. See EASE_OUT_EXPO and EASE_IN_EXPO  in
sugar-toolkit/src/sugar/graphics/animator.py.

+        # Disable the Frame from popping up when a clipping is added
+        # cb_service = clipboardservice.get_instance()
+        # cb_service.connect_after('object-added',
self._clipboard_object_added_cb)

This can be completely removed, instead of commenting out.

+        # Get the screen size
+        screen = gtk.gdk.screen_get_default()

Comment doesn't match what the code does. I think that, in general, is
better to make the code clearer rather than adding comments.

Thanks,

Tomeu