[PATCH] Install customization packages left for us by a USB key.

C. Scott Ananian cscott at laptop.org
Fri Mar 7 10:11:06 EST 2008


NACK.  Blatantly insecure.  Classic privilege-escalation attack.  Why
is this being proposed, Michael?  I'd expect you to know better.
 --scott

On Fri, Mar 7, 2008 at 2:23 AM, Michael Stone <michael at laptop.org> wrote:
> ---
>   olpc-configure |   16 ++++++++++++++++
>   1 files changed, 16 insertions(+), 0 deletions(-)
>
>  diff --git a/olpc-configure b/olpc-configure
>  index d214f2c..57ec782 100755
>  --- a/olpc-configure
>  +++ b/olpc-configure
>  @@ -96,6 +96,21 @@ rebuild_library_index() {
>         fi
>   }
>
>  +install_customization_packages () {
>  +       PKGDIR=/home/olpc/.usb-customization-pkgs
>  +       if [ -d $PKGDIR ]; then
>  +               PKGS=$(find $PKGDIR -name '*.rpm')
>  +               if [ $(echo $PKGS | wc -l) -gt 0 ]; then
>  +                       echo '* olpc-configure: Installing customization packages:'
>  +                       echo $PKGS
>  +                       yum -yt --nogpgcheck install $PKGS
>  +               fi
>  +               unset PKGS
>  +               rm -rf $PKGDIR
>  +       fi
>  +       unset PKGDIR
>  +}
>  +
>   # configurations which happen in /home
>   # these don't need to be repeated when we upgrade.
>   configure_home() {
>  @@ -245,6 +260,7 @@ case "$1" in
>         if [ -f "$OLPC_HOME/.usb-customizations" ]; then
>                 olpc_usb_version="`cat $OLPC_HOME/.usb-customizations 2>/dev/null`"
>                 if [ -n "$olpc_usb_version" ] && [ "$olpc_usb_version" -ge "1" ]; then
>  +                       install_customization_packages
>                         rebuild_library_index
>                 fi
>
>  --
>  1.5.3.3
>
>  _______________________________________________
>  Devel mailing list
>  Devel at lists.laptop.org
>  http://lists.laptop.org/listinfo/devel
>



-- 
                         ( http://cscott.net/ )



More information about the Devel mailing list