[PATCH #3355] Add sysfs support for powering down the OLPC 88W8838 wireless chip.

[Deepak Saxena]

On Jun 13 2008, at 20:05, Chris Ball was caught saying:
> Hi Deepak,
> 
>    > I think the preffered way to do this is via sscanf() of the
>    > incoming buffer as you can catch errors such as non-integer
>    > input. simple_stroul() will just return 0 which is not what we
>    > want.
> 
>    > I'd also change the mode to 0400 as this is a write-only bit.
> 
>    > My preffered option is to make it r/w, call it wlan_enabled and
>    > than we could check the state via the file too by storing the
>    > current setting.
> 
> All applied in the replacement patch below.  Thanks!

Looks good. 

~Deepak


-- 
Deepak Saxena <dsaxena at laptop.org>