David Woodhouse dwmw2 at infradead.org
Tue Feb 26 19:04:00 EST 2008

On Mon, 2008-02-25 at 04:37 -0500, John Watlington wrote:
> http://dev.laptop.org/~wad/wireshark-0.99.7.mesh.patch

Has this been submitted to the wireshark developers? I took a quick look
through it and removed some whitespace noise, and spotted a change in
add_fixed_field() behaviour in the CAT_HT case. It used to lack a break;
and thus fall through to the default: case. But now it doesn't, because
you added a break there before your new code for CAT_VENDOR_SPECIFIC.

If you really mean that as a bug fix, it should be submitted as a
separate patch instead of a subtle side-effect of the mesh support.

On a similar note -- in dissect_snap() in packet-llc.c, are you
intentionally falling through to the OUT_ENCAP_ETHER case? If so, it's
probably worth a comment to that effect.


More information about the Devel mailing list