[PATCH] cafe_nand: remove busy-wait loop

Deepak Saxena dsaxena at laptop.org
Tue Dec 9 14:45:16 EST 2008


On Dec 09 2008, at 16:05, Daniel Drake was caught saying:
> This patch enables interrupts for DMA and command completion events, and
> uses them to determine when commands and transfers have completed.
> 
> This avoids a busy-wait loop which was a waste of CPU time.
> 
> Signed-off-by: Daniel Drake <dsd at laptop.org>

Looks good, but since we're just checking for one bit, I think
we can we just use an atomic_t instead of needing a whole spinlock.

~Deepak

-- 
 Deepak Saxena - Kernel Developer, One Laptop Per Child
   _____   __o                                   (o>
------    -\<,  Give One Laptop, Get One Laptop  //\
 ----- ( )/ ( )  http://www.amazon.com/xo        V_/_
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



More information about the Devel mailing list