Datastore profiling

Eben Eliason eben.eliason at gmail.com
Wed Aug 13 11:20:46 EDT 2008


On Wed, Aug 13, 2008 at 11:09 AM, riccardo <riccardo.lucchese at gmail.com> wrote:
> On Wed, 2008-08-13 at 11:41 +0200, Tomeu Vizoso wrote:
> < ... >
>> It is updating the "what" combobox in the toolbar, see
>> SearchToolbar.refresh_filters().
>>
>> This of course could be optimized in the same way that the list view
>> update is, by only refreshing once the journal comes visible again. To
>> check if this is worth doing, I'd do manually the user action you are
>> trying to make faster with and without refresh_filters() being called
>> and would check if there's a significant difference.
> Commenting the call to refresh_filters() makes the journal take only
> around 3% of the cpu.
>
> < ...>
>> We already have a cache for svg icons, but in this case s.g.combobox
>> is using a gtk.CellRendererPixbuf which doesn't use s.g.icon. We
>> should probably do our CellRenderer that uses s.g.icon, this would
>> give us colored icons, badges, etc. Good catch!

Note that we actually need this anyway, to close out tickets like
#7741 and #3363.  And as #7578 says, we should be coloring activity
icons everywhere they occur, never assuming the defaults are correct,
so we need this to be possible anywhere we might use an icon.

- Eben

> yeah, most of the time in refresh_filters() goes to icons rendering.
>
>
>> Thanks,
>>
>> Tomeu
>
> _______________________________________________
> Devel mailing list
> Devel at lists.laptop.org
> http://lists.laptop.org/listinfo/devel
>



More information about the Devel mailing list