[PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

Bernardo Innocenti bernie at codewiz.org
Tue Sep 25 11:50:47 EDT 2007


Andres Salomon wrote:

>> On the GX, we *save* them always and restore them only on powerup.
>> Saving the registers is needed because, later on, we peek a few values
>> from that structure for powering up the video unit.
> 
> Er, brain fart.  We don't want to be calling lx_graphics_{en,dis}able when
> transitioning to state 2; that shuts down too many things.  That's what
> I meant to say.

Then we'd be doing nothing at all in state 2!  We'd be better off *not*
calling the fb_power hook from fbmem.c in the first place.

I thought all that was meant to save power when DCON is frozen.  Otherwise,
ajax's patch for freezing DCON would be pretty pointless, wouldn't it?

Btw, I feel this patch would also fix the funny artifacts we observed when
we applied ajax's patch for X11.  What do you think?


>> This rework will take some time.  Could we push it after Trial3?  For now, I see
>> this patch as a quick bugfix only.  And the change brings the fb_power() API
>> somewhat *closer* to what would be needed for switching to fb_

... I meant to say "fb_blank()" here, of course.  How do you feel about this?

-- 
 \___/
 |___|  Bernardo Innocenti - http://www.codewiz.org/
  \___\ One Laptop Per Child - http://www.laptop.org/


More information about the Devel mailing list