[PATCH] GEODE: decouple sleep/resume from powerdown/powerup

Pavel Machek pavel at ucw.cz
Fri Oct 5 09:15:31 EDT 2007


Hi!

> This patch merges the fb_powerup and fb_powerdown hooks in a single
> operation fb_power with an additional "state" parameter ranging
> from 0 (running) to 3 (poweroff).

No, please don't. Having int with 0/3 being valid specifying what to
do is evil.

enum is less evil, but what's wrong about having 3 functions?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



More information about the Devel mailing list