[PATCH] Retry frame transmission when libertas driver is busy.

Dan Williams dcbw at redhat.com
Sat Nov 3 15:23:21 EDT 2007


On Fri, 2007-11-02 at 16:17 -0700, Javier Cardona wrote:
> Andres,
> 
> On 11/2/07, Andres Salomon <dilinger at queued.net> wrote:
> > On Fri, 02 Nov 2007 12:54:35 -0700 (PDT)
> > Ashish Shukla <javier at cozybit.com> wrote:
> >
> > So, uh.. This patch is from Javier, but was originally written by
> > Ashish?  Did I get the attribution right? :)
> 
> It's from Ashish.  I just verified it and forwarded it on his behalf.
> 
> > Is this simply a workaround to make the driver more reliable with the
> > (broken) p0 firmware, or is it an actual fix (ie, is the proper
> > behavior to be returning NETDEV_TX_BUSY rather than dropping packets)?
> 
> It's an actual fix:  the driver should not drop frames in that
> situation.  There is also a firmware fix that the QA team has tested
> together with this patch.

Can we please post these patches to linux-wireless if they don't contain
any OLPC-specific ioctls and such?  Even if they do, the generic parts
that don't touch ioctl.c can get posted on linux-wireless too.
Otherwise Andres is going to have a _really_ nasty time merging with new
kernel releases.

Dan





More information about the Devel mailing list