[Code-review] /etc/init.d/rainbow

[Martin Dengler]

On Thu, Jun 26, 2008 at 04:19:19PM -0400, Michael Stone wrote:
> On Tue, Jun 24, 2008 at 01:44:39AM +0100, Martin Dengler wrote:
> > --- /etc/init.d/rainbow.orig	2008-05-19 18:58:05.000000000 +0000
> > +++ /etc/init.d/rainbow	2008-05-19 18:57:55.000000000 +0000
> > @@ -76,7 +76,7 @@
> >  		reload
> >  		;;
> >  	status)
> > -		status $DAEMON
> > +		status -p $PID_FILE $prog
> 
> I'm not familiar with the 'status' program and I don't have its man page
> handy. Could you please tell me what this change accomplishes?

It makes "/etc/init.d/rainbow status" actually work.  Right now it's
calling status with the wrong argument(s), as /etc/init.d/rainbow
doesn't have $DAEMON set to what the pidof-ish functions in
/etc/rc.d/init.d/functions shell script function collection expect.

So /etc/init.d/rainbow status is always returning "stopped" now,
without this patch.

> Thanks,
> 
> Michael

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/code-review/attachments/20080626/258b96f7/attachment.pgp