[Code-review] manual-wireless.py
ffm
ffm at cluenet.org
Thu Jul 10 17:22:25 EDT 2008
Martin Dengler wrote:
>> Any comments?
>
> Some of the best comments you could get will point out where you've
> done something particularly well, or highlighting an area where you
> appear to have a fruitful line of investigation ahead of you that will
> lead to a fun area others have explored. Unfortunately my comments
> won't be as helpful, I fear. The ones marked with an asterisk should
> be taken with a grain of salt:
>
> manual-wireless.py:
> [snip]
Thanks so much!
> getone.py:
> - instead of mkdir(), consider os.mkdirs()
>
You mean os.makedirs()? It doesn't silently accept already-existant dirs.
Attached is the revised version of my code.
> Martin
-FFM
-------------- next part --------------
A non-text attachment was scrubbed...
Name: getone.py
Type: text/x-python
Size: 1989 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/code-review/attachments/20080710/fbeac3da/attachment.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: manual-wireless.py
Type: text/x-python
Size: 10160 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/code-review/attachments/20080710/fbeac3da/attachment-0001.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.laptop.org/pipermail/code-review/attachments/20080710/fbeac3da/attachment.pgp
More information about the Code-review
mailing list