[Code-review] review: Gadget alias branch
Dafydd Harries
dafydd.harries at collabora.co.uk
Tue Aug 19 05:59:11 EDT 2008
Ar 18/08/2008 am 10:47, ysgrifennodd Guillaume Desmottes:
> Le vendredi 15 août 2008 à 20:24 +0100, Dafydd Harries a écrit :
> > This branch mostly looks great. Again, just one thing to change:
> >
> > >+ alias = elem.getAttribute('alias')
> > >+
> > >+ q.append(('search', jid, props, alias))
> >
> > We should insert a:
> >
> > if alias == '':
> > alias = None
> >
> > If the alias attribute is '', then it will match every buddy, which I don't
> > think is what we want.
>
> I already check that here:
>
> + if alias is not None:
> + # have to check alias
> + if buddy.alias is None or not alias_match(buddy.alias, alias):
> + return False
The attribute might be present, but with an empty value. We should check for
that too, no?
--
Dafydd
More information about the Code-review
mailing list