[Code-review] review: Gadget members branch

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Wed Aug 13 11:25:13 EDT 2008


Le mercredi 13 août 2008 à 15:52 +0100, Dafydd Harries a écrit :
> > > Why might we have an invalid buddy ID to begin with?
> > 
> > If a contact joins the activity room but is not subscribed to Gadget.
> > Then Gadget doesn't know his properties.
> 
> Ah, right. Perhaps we should have a comment in the code to explain.
> 
I added a comment explaining this.


> Ok, let's merge it.

act-props and members are now merged.


Thanks for the review,


	G.




More information about the Code-review mailing list