[Code-review] review: Gadget act-props branch

[Dafydd Harries]

Ar 13/08/2008 am 14:47, ysgrifennodd Guillaume Desmottes:
> Le mercredi 13 août 2008 à 12:42 +0100, Dafydd Harries a écrit :
> > > > > > >    for child in node.elements():
> > > > > > >+        if child.uri == ns.ACTIVITY_PROP and child.name == 'properties':
> > > > > > >+            for child in child.elements():
> > > > > > >+                assert child.name == 'property'
> > > > > > 
> > > > > > I think it's better to just ignore unexpected elements:
> > > > > > 
> > > > > >   for child in child.elements():
> > > > > >       if child.name != 'property':
> > > > > >           continue
> > 
> > Oops: I didn't realise that this was in the test code. I don't think it
> > matters there.
> 
> 
> I already changed it so...
> 
> OK, to merge act-props in its current state?

Yep, looks fine.

-- 
Dafydd