[Code-review] review: Gadget current-activity branch
guillaume.desmottes at collabora.co.uk
Tue Aug 12 07:06:47 EDT 2008
Le lundi 11 août 2008 à 17:13 +0100, Dafydd Harries a écrit :
> >+ # (room, activity id)
> >+ self.current_activity = ('', '')
> Why not make this an activity object? (Or None for no current activity.)
Then that implies that if Gadget is notified about a current-act change
involving an activity which is not in Gadget's model, we'll have to set
buddy's current-act to None.
Is that something we want? IIRC, we agreed that Gadget should always fw
notifications and that's client's job to ignore this notification if
that's an unknown activity.
> >+ # FIXME: what about buddies who are in activity views as
> >+ # participants ?
> I don't understand this comment. Could you elaborate?
I rephrased it to:
# FIXME: We only notify changes to buddy views. But buddies can also
# be in activity views (as participants). We should send notification
# messages in that case too.
More information about the Code-review