[Code-review] review: Gadget current-activity branch

Guillaume Desmottes guillaume.desmottes at collabora.co.uk
Mon Aug 11 14:23:11 EDT 2008


Le lundi 11 août 2008 à 17:49 +0100, Dafydd Harries a écrit :
> >+    def remove_buddy(self, buddy):
> >+        self.results.remove(buddy)
> >+        self.handler.buddy_removed(buddy)
> 
> Perhaps we can add a FIXME here; something like:
> 
>   # FIXME: add more results here if len(self.results) <= self.size
> 
good point. done.

> Otherwise, +1.
> 

view-size merged to master.


	G.





More information about the Code-review mailing list