#11847 HIGH -: Firmware q2f10: Test Hardware: If fails power off

[Zarro Boogs per Child]

#11847: Firmware q2f10: Test Hardware: If fails power off
-------------------------------------------+--------------------------------
           Reporter:  earias               |       Owner:  quozl at laptop.org    
               Type:  defect               |      Status:  reopened            
           Priority:  high                 |   Milestone:                      
          Component:  ofw - open firmware  |     Version:  Development firmware
         Resolution:                       |    Keywords:                      
        Next_action:  review               |    Verified:  0                   
Deployment_affected:                       |   Blockedby:                      
           Blocking:                       |  
-------------------------------------------+--------------------------------

Comment(by reuben):

 Replying to [comment:8 Quozl]:
 > Replying to [comment:7 reuben]:
 > > Replying to [comment:6 Quozl]:
 > > > Reuben, I remain in doubt as to my comprehension of your
 requirements, sorry.  Here's a proposed behaviour:
 > > >
 > > >  * You want to be able to interrupt the automatic test using the
 escape key, be given the test menu, and resume manual control?
 > >
 > > From my understanding: When the automatic tests are escaped using only
 the *escape* key, they should be given the test menu, and should be able
 to navigate the test menu. The test menu should allow them to run
 additional tests or move to the stop button to power off.
 >
 > Thanks.  Escape key was being ignored in the two second countdown after
 each test.  That's just after the "Okay" but before the menu refreshes.  I
 have fixed that.
 >
 > > >  * You want a test failure, (such as the SD test in Q2F10), to
 proceed to the next test, and when all tests are done to redisplay the
 test menu, and resume manual control?
 > >
 > > In the event of test failure, the testing process should be paused,
 requiring user intervention to acknowledge the test failure, and then
 pressing any key then should resume the testing process.
 >
 > Okay.  I have implemented that.
 >
 > > I believe in both cases when the tests have finished the unit should
 power-off.
 >
 > I don't like that, because power off is indistinguishable from unit
 failure.
 >
 > In Q2F10, when all tests have passed it says "All automatic tests passed
 successfully" on a green background, and waits for any key.
 >
 > I propose that for an all tests run that contains at least one test
 fail, it should say "Some tests failed" on a red background, and wait for
 any key.  I have implemented that.
 >
 > Alternatively, these two messages could be omitted, leaving the exit
 icon selected, and the coloured borders around each test will indicate the
 success or failure.

 I like this alternative idea. A common request is a report at the end of
 testing summarizing all tests passed or showing which tests failed.

 >
 > Please test http://dev.laptop.org/~quozl/q2f11jf.rom
 >
 > Test cases
 >  * gamekey-auto-menu then hit escape immediately, should exit,
 >  * gamekey-auto-menu then navigate to exit, should exit,
 >  * gamekey-auto-menu then do not interact, should start tests, at end of
 tests should display result, then should return to menu with exit button
 active,
 >  * as above but press escape during the Okay pause after a test, should
 return to menu,
 >  * that a failed test causes the test to be reported, and the end of
 tests should report some tests failed.
 >
 > To force a test fail of the CPU test,
 > {{{
 > ok dev /cpu
 > ok patch true false selftest
 > ok dend
 > }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/11847#comment:10>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system