#12055 NORM Not Tri: OFW should sanity-check size of .zd files before starting to write them
Zarro Boogs per Child
bugtracker at laptop.org
Sun Aug 19 14:22:25 EDT 2012
#12055: OFW should sanity-check size of .zd files before starting to write them
---------------------------------+------------------------------------------
Reporter: cjb | Owner: Quozl
Type: enhancement | Status: new
Priority: normal | Milestone: Not Triaged
Component: ofw - open firmware | Version: not specified
Keywords: | Next_action: never set
Verified: 0 | Deployment_affected:
Blockedby: | Blocking:
---------------------------------+------------------------------------------
The failure mode I'm trying to protect against is the one where you only
have a partial download of the file, and you only realize it after fs-
update spends five minutes flashing and then says "Short read of zdata
file" unexpectedly. It would save time (and wondering about why it
failed) for it to immediately tell you that there's no way the .zd file
you've provided can be complete, instead of waiting until it runs out of
data.
We should store the ultimate file size in bytes in a header of the .zd
file, and test it against the file size on disk before doing anything
else.
--
Ticket URL: <http://dev.laptop.org/ticket/12055>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system
More information about the Bugs
mailing list