#11328 HIGH 11.3.0: recent alc5631 commit partially breaks audio playback

[Zarro Boogs per Child]

#11328: recent alc5631 commit partially breaks audio playback
--------------------+-------------------------------------------------------
 Reporter:  dsd     |                 Owner:  saadia       
     Type:  defect  |                Status:  new          
 Priority:  high    |             Milestone:  11.3.0       
Component:  kernel  |               Version:  not specified
 Keywords:          |           Next_action:  never set    
 Verified:  0       |   Deployment_affected:               
Blockedby:          |              Blocking:               
--------------------+-------------------------------------------------------
 The following commit introduces an audio playback regression:

 {{{
 commit b9706cff6344737fea54b07d18e62738d4a4a8fd
 Author: Saadia Baloch <saadia at laptop.org>
 Date:   Fri Oct 7 11:06:33 2011 -0400

     alc5631.c: Changed sense of DC mode setting, and cleaned up many
 register settins.
     Many register settings have been modified to only write/clear certain
 bits.
     Headphone output is dependent on jack detection, which is not working
 correctly.

     Signed-off-by: Saadia Baloch <saadia at laptop.org>
 }}}

 Test case: `speaker-test -c 2 -t wav` will only play one of the two sounds
 - the other is silent. Might have to run the command a few times to
 reproduce this.

 Reverting the above commit solves the problem, and also allows my fix in
 #11296 to work (otherwise, while the mmap error is gone, silence is
 produced).

 As a new build will be made today, which will be presented to Quanta for
 evaluation, we should fix this soon or just temporarily revert the commit.

-- 
Ticket URL: <http://dev.laptop.org/ticket/11328>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system