#10817 HIGH 11.2.0-: friendstray does represent buddies of a shared activity we have not joined yet

[Zarro Boogs per Child]

#10817: friendstray does represent buddies of a shared activity we have not joined
yet
------------------------------+---------------------------------------------
           Reporter:  erikos  |       Owner:  erikos                           
               Type:  defect  |      Status:  new                              
           Priority:  high    |   Milestone:  11.2.0-M4                        
          Component:  sugar   |     Version:  Development build as of this date
         Resolution:          |    Keywords:  collaboration                    
        Next_action:  review  |    Verified:  0                                
Deployment_affected:          |   Blockedby:                                   
           Blocking:          |  
------------------------------+---------------------------------------------
Changes (by erikos):

  * next_action:  code => review


Comment:

 {{{
 diff --git a/src/jarabe/frame/friendstray.py
 b/src/jarabe/frame/friendstray.py
 index 31a9809..4055340 100644
 --- a/src/jarabe/frame/friendstray.py
 +++ b/src/jarabe/frame/friendstray.py
 @@ -75,6 +75,10 @@ class FriendsTray(VTray):
      def __neighborhood_activity_added_cb(self, neighborhood_model,
                                           shared_activity):
          logging.debug('FriendsTray.__neighborhood_activity_added_cb')
 +        active_activity = shell.get_model().get_active_activity()
 +        if active_activity.get_activity_id() !=
 shared_activity.activity_id:
 +            return
 +
          self.clear()

          # always display ourselves
 }}}

 The code path that listens for the 'activity-added' signal is used to
 track the following use case: 'A' starts an activity (he gets the 'active-
 activity-changed' signal from the shell), he then at a later point shares
 the activity. In order to track joining/leaving buddies he needs to get
 the shared activity. On other machines if we receive the 'activity-added'
 signal we can ignore it, therefore the check if the current active
 activity is the shared one.

-- 
Ticket URL: <http://dev.laptop.org/ticket/10817#comment:2>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system