#10771 NORM 11.2.0-: Paint undo functionality with clippings seems to often cause duplication

[Zarro Boogs per Child]

#10771: Paint undo functionality with clippings seems to often cause duplication
--------------------------------------------------------+-------------------
           Reporter:  greenfeld                         |       Owner:  godiard                          
               Type:  defect                            |      Status:  new                              
           Priority:  normal                            |   Milestone:  11.2.0-M3                        
          Component:  paint/drawing-activity (oficina)  |     Version:  Development build as of this date
         Resolution:                                    |    Keywords:                                   
        Next_action:  code                              |    Verified:  0                                
Deployment_affected:                                    |   Blockedby:                                   
           Blocking:                                    |  
--------------------------------------------------------+-------------------
Changes (by godiard):

  * next_action:  review => code


Comment:

 The patch is better, and resolve the problem you detected, but does not
 resolve the issue detailed in the bug. When you do a operation with a
 selection (like select a area a move it or copy/paste)
 AND the selection is active, AND you try to do undo, the selection is
 displayed over the image, and then is confusing to the user. If the
 selection is not active I think is working ok.

 Then I think you must deactivate the selection before doing undo.

 You can see this code is not so easy, need a lot of testing.

 Looking at the code, in the mouseup method, I can see the only tool what
 does not do enableUndo is the freeform tool. I have tested and the undo
 with the freeform tool is not working. May be is better create another
 ticket to solve the undo/redo in the freeform tool.

-- 
Ticket URL: <http://dev.laptop.org/ticket/10771#comment:9>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system