#10750 HIGH 11.2.0-: gabble: nick name is set to jabber_account_id

[Zarro Boogs per Child]

#10750: gabble: nick name is set to jabber_account_id
------------------------------+---------------------------------------------
           Reporter:  erikos  |       Owner:  erikos                           
               Type:  defect  |      Status:  new                              
           Priority:  high    |   Milestone:  11.2.0-M4                        
          Component:  sugar   |     Version:  Development build as of this date
         Resolution:          |    Keywords:  collaboration                    
        Next_action:  code    |    Verified:  0                                
Deployment_affected:          |   Blockedby:                                   
           Blocking:          |  
------------------------------+---------------------------------------------
Changes (by erikos):

  * next_action:  diagnose => code


Comment:

 Actually, we do seem to get the correct nick information but we did not
 update the buddy because of checking for a wrong property key:

 {{{
 diff --git a/src/jarabe/model/neighborhood.py
 b/src/jarabe/model/neighborhood.py
 index 7004283..828cb14 100644
 --- a/src/jarabe/model/neighborhood.py
 +++ b/src/jarabe/model/neighborhood.py
 @@ -929,8 +929,9 @@ class Neighborhood(gobject.GObject):
          if 'key' in properties:
              buddy.props.key = properties['key']

 -        if 'nick' in properties:
 -            buddy.props.nick = properties['nick']
 +        nick_key = CONNECTION_INTERFACE_ALIASING + '/alias'
 +        if nick_key in properties:
 +            buddy.props.nick = properties[nick_key]

          if is_new:
              self.emit('buddy-added', buddy)
 }}}

 I checked that in all the cases (alias-change or when we do get the buddy
 information in various ways) the key is "CONNECTION_INTERFACE_ALIASING +
 '/alias'".

-- 
Ticket URL: <http://dev.laptop.org/ticket/10750#comment:3>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system