#8857 HIGH 9.1.0-c: Browse fails to download some files with non-ascii characters

[Zarro Boogs per Child]

#8857: Browse fails to download some files with non-ascii characters
---------------------------------------+------------------------------------
           Reporter:  tomeu            |       Owner:  erikos             
               Type:  defect           |      Status:  new                
           Priority:  high             |   Milestone:  9.1.0-cancelled    
          Component:  browse-activity  |     Version:                     
         Resolution:                   |    Keywords:  8.2.1:? cjbfor9.1.0
        Next_action:  code             |    Verified:  0                  
Deployment_affected:                   |   Blockedby:                     
           Blocking:                   |  
---------------------------------------+------------------------------------

Comment(by godiard):

 I have tested in 117 and needed to aplly the following change:

 {{{
 diff --git a/downloadmanager.py b/downloadmanager.py
 index 24d3911..8736af5 100644
 --- a/downloadmanager.py
 +++ b/downloadmanager.py
 @@ -137,8 +137,9 @@ class Download:
          self._last_update_percent = 0
          self._stop_alert = None

 -        dom_window = _dest_to_window[self._target_file.path]
 -        del _dest_to_window[self._target_file.path]
 +        file_path = self._target_file.path.encode('utf-8', 'replace')
 +        dom_window = _dest_to_window[file_path]
 +        del _dest_to_window[file_path]

          view = hulahop.get_view_for_window(dom_window)
          logging.debug('Download.init dom_window: %r' % dom_window)
 }}}

 In Browse 108 (the version in 10.1.2) the solution it's the same.

-- 
Ticket URL: <http://dev.laptop.org/ticket/8857#comment:8>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system