#10308 NORM 10.1.3: When owner leaves, shared activity does not always go away on his own view (link-local)

Zarro Boogs per Child bugtracker at laptop.org
Mon Oct 18 15:55:29 EDT 2010


#10308: When owner leaves, shared activity does not always go away on his own view
(link-local)
----------------------------------------+-----------------------------------
           Reporter:  erikos            |       Owner:  erikos                           
               Type:  defect            |      Status:  new                              
           Priority:  normal            |   Milestone:  10.1.3                           
          Component:  presence-service  |     Version:  Development build as of this date
         Resolution:                    |    Keywords:                                   
        Next_action:  review            |    Verified:  0                                
Deployment_affected:                    |   Blockedby:                                   
           Blocking:                    |  
----------------------------------------+-----------------------------------
Changes (by erikos):

  * next_action:  code => review


Comment:

 {{{
 diff --git a/src/activity.py b/src/activity.py
 index 29ba1a5..6c5825c 100644
 --- a/src/activity.py
 +++ b/src/activity.py
 @@ -1143,6 +1143,7 @@ class Activity(ExportedGObject):
          # we've joined.
          if self._joined:
              self._remove_buddies(removed_buddies)
 +            self._claimed_buddies -= removed_buddies

          # if we were among those removed, we'll have to start believing
          # the spoofable PEP-based activity tracking again.
 }}}

 Looks like the fix is as "simple" as that. Testes for Salut and verified
 that it does not break anything on Gabble. (Mind that due to salut vs
 collaboration there might be occasions where we still see leftover sharing
 activities on some neighborhood views. To be 100% where the issue might be
 we need to first test with idle suspend disabled)

-- 
Ticket URL: <http://dev.laptop.org/ticket/10308#comment:3>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list