#10364 NORM 10.1.3: Home button in Browse
Zarro Boogs per Child
bugtracker at laptop.org
Tue Oct 5 06:25:10 EDT 2010
#10364: Home button in Browse
---------------------------------------+------------------------------------
Reporter: erikos | Owner: godiard
Type: defect | Status: new
Priority: normal | Milestone: 10.1.3
Component: browse-activity | Version: Development build as of this date
Resolution: | Keywords:
Next_action: test in build | Verified: 0
Deployment_affected: | Blockedby:
Blocking: |
---------------------------------------+------------------------------------
Comment(by erikos):
0.84 patch comments:
{{{
self._go_home.set_tooltip(_('Home page'))
}}}
I wonder if we should set this to the title of the page it will load (i.e.
SugarLabs, OLPC...). We have an issue here as well of introducing a new
string. Not 100% sure yet how best to handle that.
{{{
self._go_home.props.sensitive = True
}}}
You don't need to set it to True manually.
{{{
self._go_home.connect('clicked', self._go_home_cb)
}}}
Normally self.__go_home_cb, but since the other callbacks are named with
one underscore here too - let's keep it to be in sync with the code
around.
Please use a signal to propagate to the activity that the home button has
been pressed (see add-link as an example). That way you only have to pass
the browser instance and not the activity instance.
I think we mainly settled on an icon. Just pick the last one we have been
advocating for.
--
Ticket URL: <http://dev.laptop.org/ticket/10364#comment:5>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system
More information about the Bugs
mailing list