#9323 NORM 1.5-sof: viafb corruption after switching from X back to viafb

Zarro Boogs per Child bugtracker at laptop.org
Thu Jun 3 13:14:24 EDT 2010


#9323: viafb corruption after switching from X back to viafb
------------------------------------+---------------------------------------
           Reporter:  cjb           |       Owner:  cjb               
               Type:  defect        |      Status:  new               
           Priority:  normal        |   Milestone:  1.5-software-later
          Component:  kernel        |     Version:  not specified     
         Resolution:                |    Keywords:                    
        Next_action:  add to build  |    Verified:  0                 
Deployment_affected:                |   Blockedby:                    
           Blocking:                |  
------------------------------------+---------------------------------------
Changes (by cjb):

  * owner:  dsaxena => cjb
  * next_action:  diagnose => add to build


Comment:

 These look good to me; please fix the indentation and extra braces in the:

 {{{
 +    } else if (reg < ARRAY_SIZE(via_eng_reg))
 +               reg = via_eng_reg[reg];
 }}}

 hunk, and we might as well s/Reverse/Reserve/ in the comment on the second
 patch, even though that was already mis-spelled upstream before you moved
 it.

 Perhaps mail these over to linux-fbdev@ for upstream review too?  We
 should also get them in an unstable build for testing.

-- 
Ticket URL: <http://dev.laptop.org/ticket/9323#comment:17>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list