#10016 LOW 1.5-sof: os109 -- Icon in Frame did not have session associated with it

[Zarro Boogs per Child]

#10016: os109 -- Icon in Frame did not have session associated with it
--------------------------------+-------------------------------------------
           Reporter:  mikus     |       Owner:  dsd                              
               Type:  defect    |      Status:  new                              
           Priority:  low       |   Milestone:  1.5-software-later               
          Component:  sugar     |     Version:  Development build as of this date
         Resolution:            |    Keywords:                                   
        Next_action:  diagnose  |    Verified:  0                                
Deployment_affected:            |   Blockedby:                                   
           Blocking:            |  
--------------------------------+-------------------------------------------

Comment(by Quozl):

 A race condition exists in the following way:

  * ActivityIcon._activate() is asked to resume an activity from the
 Journal, and so tries to use the same activity_id as the saved Journal
 entry defined.

  * the shell is asked whether the activity is currently active, using
 shell.get_model().get_activity_by_id(), which returns false for the first
 click,

  * the launcher is started,

  * the journal.misc.resume() method asks the activity factory to ask DBus
 to create an instance of the activity (hand waving stuff here),

  * once the activity startup is underway, the shell is informed through
 the window manager properties (more hand waving),

  * but before the shell is informed, the second click arrives,
 ActivityIcon._activate() executes, using the same activity id,

  * the launcher is '''not''' duplicated because the launcher already is
 active for this activity id, (see launcher.add_launcher()'s check of
 _launchers),

  * the journal.misc.resume() method happens again for the same activity
 id.

 The inconsistency in the Frame will be due to the lack of launcher
 completion for the second instance.

 The inconsistency in Alt/Tab will be due to the duplicate activity id.

-- 
Ticket URL: <http://dev.laptop.org/ticket/10016#comment:4>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system