#10494 NORM 10.1.3: Scrolling does not work for epub files in Read activity

[Zarro Boogs per Child]

#10494: Scrolling does not work for epub files in Read activity
-------------------------------------+--------------------------------------
           Reporter:  greenfeld      |       Owner:  erikos                           
               Type:  defect         |      Status:  new                              
           Priority:  normal         |   Milestone:  10.1.3                           
          Component:  read-activity  |     Version:  Development build as of this date
         Resolution:                 |    Keywords:                                   
        Next_action:  review         |    Verified:  0                                
Deployment_affected:                 |   Blockedby:                                   
           Blocking:                 |  
-------------------------------------+--------------------------------------
Changes (by godiard):

 * cc: godirad (removed)
 * cc: godiard (added)
  * next_action:  code => review


Comment:

 The change necessary is

 {{{
 [root at xo-a7-2b-49 epubview]# diff -u epubview.py /tmp/epubview.py
 --- epubview.py 2010-10-21 11:46:16.000000000 +0000
 +++ /tmp/epubview.py    2010-12-23 12:49:40.122217525 +0000
 @@ -528,7 +528,7 @@
              self._scroll_page()

      def _load_next_file(self):
 -        if self._loaded_page == self._pagecount or not
 self._view.get_load_status() is webkit.LOAD_FINISHED:
 +        if self._loaded_page == self._pagecount:
              return
          cur_file = self._paginator.get_file_for_pageno(self._loaded_page)
          pageno = self._loaded_page
 @@ -548,7 +548,7 @@
                  break

      def _load_prev_file(self):
 -        if self._loaded_page == 1 or not self._view.get_load_status() is
 webkit.LOAD_FINISHED:
 +        if self._loaded_page == 1:
              return
          cur_file = self._paginator.get_file_for_pageno(self._loaded_page)
          pageno = self._loaded_page
 @@ -560,8 +560,6 @@
          self._load_page(pageno)

      def _scrollbar_change_value_cb(self, range, scrolltype, value):
 -        if not self._view.get_load_status() is webkit.LOAD_FINISHED:
 -            return
          if scrolltype == gtk.SCROLL_STEP_FORWARD:
              self.__going_fwd = True
              self.__going_back = False

 }}}

 I tested it and works like in 10.1.2

 I have checked the pywebkit API and i can't found a method similar to
 replace it.

 In master the change is done.

 I can't provide a git patch because the epub support is not in git in 0.84

-- 
Ticket URL: <http://dev.laptop.org/ticket/10494#comment:9>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system