#3448 HIGH Future : Need for a sugarized color picker

[Zarro Boogs per Child]

#3448: Need for a sugarized color picker
----------------------------------------+-----------------------------------
           Reporter:  uwog              |       Owner:  marco         
               Type:  defect            |      Status:  new           
           Priority:  high              |   Milestone:  Future Release
          Component:  interface-design  |     Version:                
         Resolution:                    |    Keywords:  r+, 0.9.1?    
        Next_action:  review            |    Verified:  0             
Deployment_affected:                    |   Blockedby:                
           Blocking:                    |  
----------------------------------------+-----------------------------------
Changes (by tomeu):

  * keywords:  r?, 0.9.1? => r+, 0.9.1?


Comment:

 r+ with some small nitpicks:

 {{{
 (03:38:16 PM) tomeu: benzea: would be very nice if we could put the scale
 creating code in a func instead of copying it three times, even if the
 argument list is a bit long
 (03:40:00 PM) tomeu:         self._swatch_tray.props.n_columns =
 (len(colors)+rows-1) / rows
 (03:40:11 PM) tomeu: operators should have spaces around them
 (03:40:35 PM) tomeu:             button.connect('clicked',
 self._swatch_button_clicked_cb)
 (03:40:47 PM) tomeu: better use __ so that subclasses don't break
 misteriously
 (03:41:23 PM) tomeu:         self._green_scale.connect('value-changed',
 (03:41:52 PM) tomeu: if we passed the color as user_data, we could have
 one handler instead of three
 (03:43:07 PM) tomeu:         assert type(color) == gtk.gdk.Color
 (03:43:21 PM) tomeu: may be better to use isinstance() so doesn't break in
 case someone subclasses?
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/3448#comment:16>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system