#7685 NORM 9.1.0: Alternate home layouts; fixed ring scaling; better modularization of layouts

Zarro Boogs per Child bugtracker at laptop.org
Thu Sep 11 11:15:29 EDT 2008


#7685: Alternate home layouts; fixed ring scaling; better modularization of
layouts
-------------------------+--------------------------------------------------
   Reporter:  cscott     |       Owner:  marco        
       Type:  defect     |      Status:  new          
   Priority:  normal     |   Milestone:  9.1.0        
  Component:  sugar      |     Version:  not specified
 Resolution:             |    Keywords:  r?           
Next_action:  never set  |    Verified:  0            
  Blockedby:             |    Blocking:               
-------------------------+--------------------------------------------------

Comment(by cscott):

 Rebased on origin; latest patches are at:
   http://dev.laptop.org/git/users/cscott/sugar
 and
   http://dev.laptop.org/git/users/cscott/artwork

 I made the whitespace changes mtd requested.  The 'BaseLayout' stuff is
 not so straightforward: we actually do subclass RingLayout (not some
 generic BaseLayout) and reuse many functions of *RingLayout* in
 SquareLayout, TriangleLayout, etc.  Even if I were to split out a
 BaseLayout class, SquareLayout and TriangleLayout would still inherit from
 RingLayout.  Look at the superclass method invocations in
 {{{_compute_position}}}, for example.

 In mail to sugar and devel
 (http://lists.laptop.org/pipermail/devel/2008-September/019077.html) Eben
 has proposed a deeper rewriting of this layout code.  I would like that to
 be a separate bug/feature for 9.1; this patch should be applied so that
 hopefully we can get some experience with the ideas of the Sunflower and
 properly-scaled ring-like layouts, even if that functionality is
 substantially reimplemented for 9.1 (and of course, if the rewrite doesn't
 make it for 9.1, then this patch is better than what we've got now).

 Commit to master seems appropriate at this time.

-- 
Ticket URL: <http://dev.laptop.org/ticket/7685#comment:8>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list