#8117 NORM 8.2.0 (: LidClose suspend is inhibited by a prior PowerButton resume.

Zarro Boogs per Child bugtracker at laptop.org
Tue Sep 9 18:38:40 EDT 2008


#8117: LidClose suspend is inhibited by a prior PowerButton resume.
--------------------------+-------------------------------------------------
   Reporter:  thomaswamm  |       Owner:  dsaxena                          
       Type:  defect      |      Status:  new                              
   Priority:  normal      |   Milestone:  8.2.0 (was Update.2)             
  Component:  kernel      |     Version:  Development build as of this date
 Resolution:              |    Keywords:  polish:8.2.0 relnote cjbfor8.2   
Next_action:  package     |    Verified:  0                                
  Blockedby:              |    Blocking:                                   
--------------------------+-------------------------------------------------
Changes (by dsaxena):

  * next_action:  diagnose => package


Comment:

 Following has been committed to testing branch. Should see an RPM soon:

 {{{
 commit 850b087f7daf1b0251d299cfd04a4aa7b043ba4e
 Author: Deepak Saxena <dsaxena at laptop.org>
 Date:   Tue Sep 9 15:32:14 2008 -0700

     Re-enable Lid events on wakeup

     We currently do not re-enable the lid events when we wake up, leading
     to the following bug, as per OLPC Trac #8117:

     Power button -> Suspend
     Power button -> Wake up
     Lid close -> No Suspend

     Signed-off-by: Deepak Saxena <dsaxena at laptop.org>

 diff --git a/arch/x86/kernel/olpc-pm.c b/arch/x86/kernel/olpc-pm.c
 index 9532a5b..4c758f7 100644
 --- a/arch/x86/kernel/olpc-pm.c
 +++ b/arch/x86/kernel/olpc-pm.c
 @@ -373,6 +373,15 @@ void olpc_fixup_wakeup(void)
                 /* tell the wireless module to restart USB communication
 */
                 olpc_ec_cmd(0x24, NULL, 0, NULL, 0);
         }
 +
 +       /*
 +        * Re-enable all LID events
 +        */
 +       if (olpc_board_at_least(olpc_board(0xb2))) {
 +               geode_gpio_set(OLPC_GPIO_LID, GPIO_NEGATIVE_EDGE_EN);
 +               geode_gpio_set(OLPC_GPIO_LID, GPIO_POSITIVE_EDGE_EN);
 +               geode_gpio_set(OLPC_GPIO_LID, GPIO_EVENTS_ENABLE);
 +       }
  }

  int olpc_fixup_sleep(void)
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/8117#comment:10>
One Laptop Per Child <http://laptop.org/>
OLPC bug tracking system


More information about the Bugs mailing list